[PATCH#3] fake data io module for samba
PSOMOGYI at hu.ibm.com
Mon Nov 17 04:15:10 MST 2014
> > Hi Jeremy,
> > I've added the memset to 0 now and retested the whole patch again.
> > Pls do a +1 or let me know further doubts.
> +1 from me (probably with some slight tidying
> up of the English in the man page). Ping me
> if you want to see that now.
Jeremy, feel free to fix its English as you wish without asking me, as it
doesn't change the functional sense you don't need my acknowledgement
I can incorporate into next patch if you send.
> About the question when to activate it, i am not quite sure. I guess the
> options would be, having it built always, having it not built by
> default, or having it only in the developer build. Every option has its
> pros and cons. I usually like the idea that code is always built to
> detect problems automatically, but we should prevent users from
> accidentally introducing problems with it.
I think we need it packaged, there are people (I know at least 1) who
wants to try it but won't take the effort when it needs a recompile.
Due to my experience, adding the configure option
"--with-shared-modules=..." already necessary to have it built.
I'm fine with the warning addition (is level 0 enough?).
Volker, can I prepare a next patch with a warning?
IBM Magyarországi Kft.
Infopark, Neumann János u. 1.
Phone: +36 1 382 5469
More information about the samba-technical