[PATCH] smbclient: Fix connecting to a Windows share with cached credentials.

Guenther Deschner gd at samba.org
Thu Nov 13 13:52:17 MST 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

just a heads up and although Jeremy pushed it already, this here is
wrong: It overwrites the netbios_domain with the dc_name inside the
ntlmssp engine.
Then again, when we already have the domain name, why should we look
up our own domain name again ?

I discussed some of this with Andreas today and there will be follow
up patches I believe.

Thanks,
Guenther


On 13/11/14 15:55, Andreas Schneider wrote:
+			wbc_status = wbcLookupDomainController(ntlmssp_state->domain, 0,
&dc_info);
+			if (WBC_ERROR_IS_OK(wbc_status)) {
+				ntlmssp_state->server.netbios_domain =
talloc_strdup(ntlmssp_state, dc_info->dc_name);


- -- 
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlRlGe0ACgkQSOk3aI7hFoirzQCgi26c5HRN520hF562LugOGiTk
fkUAn0WVBuz2ZJ9AduTvJlKPmkUKwLcC
=kEk3
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list