Latest leases patchset - getting there !

Jeremy Allison jra at samba.org
Thu Nov 13 13:42:39 MST 2014


On Thu, Nov 13, 2014 at 09:09:05PM +0100, Stefan (metze) Metzmacher wrote:
> Am 13.11.2014 um 08:12 schrieb Jeremy Allison:
> > On Thu, Nov 13, 2014 at 01:17:43AM +0100, Stefan (metze) Metzmacher wrote:
> >>
> >> I've integrated this with a few more tests we fail (sorry...:-)
> >>
> >> ontop17.diff.txt replaces the older ontop13.diff.txt
> >> and also includes your changes.
> > 
> > No problem. Attached are some new patches to fix the new
> > tests we fail :-). They apply on top of ontop17.diff.txt.
> > 
> > on-top-of-ontop17.patchset
> > 
> > The current state of play with this new code are:
> > 
> > request 		PASS
> > break_twice		PASS
> > nobreakself		PASS
> > upgrade			PASS
> > upgrade2		PASS
> > upgrade3		PASS
> > break			PASS
> > oplock			PASS
> > multibreak		PASS
> > breaking1		--- PASS WITH smbtorture MODIFICATION (*)
> 
> fixed in ontop17-3.diff.txt
> 
> > breaking2		--- TEST CRASHES in smbtorture.(**)
> 
> the crash is fixed in ontop17-3.diff.txt
> 
> > complex1		PASS
> > v2_epoch1		PASS
> > v2_epoch2			insane test - see below
> > v2_epoch3			insane test - see below
> 
> I've fixed those in ontop17-3.diff.txt

Looks like you added lease_version to struct share_mode_oplock,
but I don't see the patch adding this to the IDL, or the
code that sets this on lease creation.

Are you missing a posted patch ?


More information about the samba-technical mailing list