Latest leases patchset - getting there !

[Stefan (metze) Metzmacher]

Am 13.11.2014 um 21:09 schrieb Stefan (metze) Metzmacher:
> Am 13.11.2014 um 08:12 schrieb Jeremy Allison:
>> On Thu, Nov 13, 2014 at 01:17:43AM +0100, Stefan (metze) Metzmacher wrote:
>>>
>>> I've integrated this with a few more tests we fail (sorry...:-)
>>>
>>> ontop17.diff.txt replaces the older ontop13.diff.txt
>>> and also includes your changes.
>>
>> No problem. Attached are some new patches to fix the new
>> tests we fail :-). They apply on top of ontop17.diff.txt.
>>
>> on-top-of-ontop17.patchset
>>
>> The current state of play with this new code are:
>>
>> request 		PASS
>> break_twice		PASS
>> nobreakself		PASS
>> upgrade			PASS
>> upgrade2		PASS
>> upgrade3		PASS
>> break			PASS
>> oplock			PASS
>> multibreak		PASS
>> breaking1		--- PASS WITH smbtorture MODIFICATION (*)
> 
> fixed in ontop17-3.diff.txt
> 
>> breaking2		--- TEST CRASHES in smbtorture.(**)
> 
> the crash is fixed in ontop17-3.diff.txt
> 
>> complex1		PASS
>> v2_epoch1		PASS
>> v2_epoch2			insane test - see below
>> v2_epoch3			insane test - see below
> 
> I've fixed those in ontop17-3.diff.txt
> 
>> v2_complex1		FAIL (***) - Should be pass - irrelevent difference with Windows.
> 
> make test uses --target=samba3 and ignores this difference.
> 
> Just breaking2 is failing now (ontop17-3.diff.txt) ignores it for now.
> 
> todo17-3.diff.txt is my attempt to fix breaking2, but there's more work
> to be done.
> 
> more comments tomorrow or early next week...

We need to have a test that triggers oplock_timeout_handler() for leases
and fix this, for now I added a SMB_ASSERT(false);

And need a complete regression test for the home share stuff.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141113/6f937c0c/attachment.pgp>