change --picky-developer into --non-picky-developer

Jeremy Allison jra at samba.org
Wed Nov 12 17:39:45 MST 2014


On Wed, Nov 12, 2014 at 04:39:19PM -0800, Jeremy Allison wrote:
> On Thu, Nov 13, 2014 at 12:49:18AM +0100, Stefan (metze) Metzmacher wrote:
> > Hi Jeremy,
> > 
> > >>> if you want review the following patchset.
> > >>>
> > >>> The top 2 patches from
> > >>> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-picky
> > >>> are not included because I haven't tested it with 'clang' instead of 'gcc'.
> > >>> So in order force people using 'clang' to use '--disable-warnings-as-errors'
> > >>> I just make sure that autobuild uses --picky-developer for now (when
> > >>> building samba).
> > >>>
> > >>> Thanks!
> > >>
> > >> FYI - I'm going through, reviewing and pushing these !
> > 
> > Thanks!
> > 
> > > Got blocked on the early lib/tevent/tevent.c changes.
> > > 
> > > This is because lib/replace/replace.h doesn't include
> > > unistd.h so there are many warnings/errors due to
> > > missing definitions of things like STDIN_FILENO,
> > > STDOUT_FILENO, STDERR_FILENO etc.
> > > 
> > > Can I get a second Team reviewer for the following ?
> > 
> > I think that's the wrong fix, for now just push everything but the last
> > patch please.
> > 
> > I guess the correct fix would be to also include "system/filesys.h"
> 
> Too late :-). Feel free to propose a patch on top.

Oh never mind, the autobuild failed...


More information about the samba-technical mailing list