change --picky-developer into --non-picky-developer
Stefan (metze) Metzmacher
metze at samba.org
Wed Nov 12 16:49:18 MST 2014
>>> if you want review the following patchset.
>>> The top 2 patches from
>>> are not included because I haven't tested it with 'clang' instead of 'gcc'.
>>> So in order force people using 'clang' to use '--disable-warnings-as-errors'
>>> I just make sure that autobuild uses --picky-developer for now (when
>>> building samba).
>> FYI - I'm going through, reviewing and pushing these !
> Got blocked on the early lib/tevent/tevent.c changes.
> This is because lib/replace/replace.h doesn't include
> unistd.h so there are many warnings/errors due to
> missing definitions of things like STDIN_FILENO,
> STDOUT_FILENO, STDERR_FILENO etc.
> Can I get a second Team reviewer for the following ?
I think that's the wrong fix, for now just push everything but the last
I guess the correct fix would be to also include "system/filesys.h"
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: OpenPGP digital signature
More information about the samba-technical