change --picky-developer into --non-picky-developer

Jeremy Allison jra at samba.org
Wed Nov 12 14:24:25 MST 2014


On Wed, Nov 12, 2014 at 01:23:20PM -0800, Jeremy Allison wrote:
> On Wed, Nov 12, 2014 at 12:38:52PM -0800, Jeremy Allison wrote:
> > On Tue, Nov 11, 2014 at 03:12:09PM +0100, Stefan (metze) Metzmacher wrote:
> > > Hi Richard,
> > > 
> > > if you want review the following patchset.
> > > 
> > > The top 2 patches from
> > > https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-picky
> > > are not included because I haven't tested it with 'clang' instead of 'gcc'.
> > > So in order force people using 'clang' to use '--disable-warnings-as-errors'
> > > I just make sure that autobuild uses --picky-developer for now (when
> > > building samba).
> > > 
> > > Thanks!
> > 
> > FYI - I'm going through, reviewing and pushing these !
> 
> Got blocked on the early lib/tevent/tevent.c changes.

I meant lib/texpect/texpect.c of course :-). Muscle
memory from all that tevent code :-).

> unistd.h so there are many warnings/errors due to
> missing definitions of things like STDIN_FILENO,
> STDOUT_FILENO, STDERR_FILENO etc.
> 
> Can I get a second Team reviewer for the following ?
> 
> Cheers,
> 
> 	Jeremy.

> From 59314ba4b3c393eb302059b6b080b134a2222a9c Mon Sep 17 00:00:00 2001
> From: Jeremy Allison <jra at samba.org>
> Date: Wed, 12 Nov 2014 13:17:53 -0800
> Subject: [PATCH] lib: replace: Ensure replace.h includes <unistd.h> if it
>  exists.
> 
> Signed-off-by: Jeremy Allison <jra at samba.org>
> ---
>  lib/replace/replace.h | 3 +++
>  lib/replace/wscript   | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/lib/replace/replace.h b/lib/replace/replace.h
> index 3ff4e36..8b931a5 100644
> --- a/lib/replace/replace.h
> +++ b/lib/replace/replace.h
> @@ -40,6 +40,9 @@
>  #include <stdlib.h>
>  #include <stdarg.h>
>  #include <errno.h>
> +#ifdef HAVE_UNISTD_H
> +#include <unistd.h>
> +#endif
>  
>  #ifndef HAVE_DECL_EWOULDBLOCK
>  #define EWOULDBLOCK EAGAIN
> diff --git a/lib/replace/wscript b/lib/replace/wscript
> index 7bbe1d6..300b560 100644
> --- a/lib/replace/wscript
> +++ b/lib/replace/wscript
> @@ -92,6 +92,7 @@ struct foo bar = { .y = 'X', .x = 1 };
>      conf.CHECK_HEADERS('errno.h')
>      conf.CHECK_HEADERS('gcrypt.h getopt.h iconv.h')
>      conf.CHECK_HEADERS('memory.h nss.h sasl/sasl.h')
> +    conf.CHECK_HEADERS('unistd.h')
>  
>      conf.CHECK_FUNCS_IN('inotify_init', 'inotify', checklibc=True,
>                          headers='sys/inotify.h')
> -- 
> 2.1.0.rc2.206.gedb03e5
> 



More information about the samba-technical mailing list