[PATCH] lib/ldb minor fixes

[Kamen Mazdrashki]

Hi Andrew,

On Tue, Nov 11, 2014 at 9:14 AM, Andrew Bartlett <abartlet at samba.org> wrote:

> On Tue, 2014-11-11 at 05:29 +0100, Kamen Mazdrashki wrote:
> > I have update the last patch to this:
> >
> https://github.com/kamenim/samba/commit/be1808de8bc5232dd9b827f93ab0d3151653ff88
> > Also attached the whole set to this mail.
>
>
> I still want it to instead check for
>
> if (msg->elements[i].name == NULL)
>

I have  considered this also.
I have opted out for this check to be done
in ldb_schema_attribute_by_name_internal()
though, as every call for finding attribute by name end up being handled by
this function.
Hence the sanity check handles much more code paths.
I see the benefit of such check here though, so we can get a much better
error message


> Thanks,
>
> Andrew Bartlett
>
>
> --
> Andrew Bartlett                       http://samba.org/~abartlet/
> Authentication Developer, Samba Team  http://samba.org
> Samba Developer, Catalyst IT
> http://catalyst.net.nz/services/samba
>
>
>