Test infrastructure improvements

Jelmer Vernooij jelmer at samba.org
Mon Nov 10 14:06:41 MST 2014


On Mon, Nov 03, 2014 at 12:43:28PM +1300, Andrew Bartlett wrote:
> On Sun, 2014-11-02 at 23:16 +0100, Jelmer Vernooij wrote:
> > On Mon, Nov 03, 2014 at 10:13:39AM +1300, Andrew Bartlett wrote:
> > > On Sat, 2014-11-01 at 17:19 +0100, Jelmer Vernooij wrote:
> > > > On Sat, Oct 25, 2014 at 03:06:48PM -0700, Jelmer Vernooij wrote:
> > > > > Matthieu and I got together a couple of weeks ago to hack on the
> > > > > Samba testsuite.
> > > > > 
> > > > > Our main goal has so far been on reducing the overall run time of the
> > > > > testsuite, through various means. Matthieu has been pesking me about
> > > > > running tests in parallel for a long time.
> > > > > 
> > > > > I've put the todo-list we compiled on the wiki:
> > > > > https://wiki.samba.org/index.php/Test_Infrastructure_Sprint
> > > > > 
> > > > > What we have at the moment:
> > > > > 
> > > > > * drop the samba3/samba4 distinction?
> > > > I think this is a much larger change, since it ties in with other code changes
> > > > to e.g. remove the distinction between smbtorture3 and smbtorture4.
> > > > 
> > > > Perhaps we should hold off on this as part of the test infrastructure
> > > > improvements, though I agree it would be a nice thing to do in general.
> > > 
> > > At one level, the samba, samba3. and samba4. prefixes have become quite
> > > meaningless.  That is, they refer mostly to the file the tests are
> > > declared in, that is selftest/tests.py, source3/selftest/tests.py and
> > > source4/selftest/tests.py.  
> > They also refer to the version of the tools that is used to run the tests. E.g.
> > the samba3 tests use the source3 smbtorture, the samba4 ones use the source4
> > smbtorture.
> 
> No, this isn't the case.  Most of the tests in source3/selftest/tests.py
> use smbtorture, as built from source4/torture.  
That is not how it was supposed to be or how it was in the original design, but
I guess there isn't much I can change about that now...

So yeah, in that case, let's just kill the prefixes.

Cheers,

Jelmer


More information about the samba-technical mailing list