Shouldn't at least the last two of these be fixed?

[Richard Sharpe]

On Sat, Nov 8, 2014 at 4:10 PM, Richard Sharpe
<realrichardsharpe at gmail.com> wrote:
> I was building the latest master and saw this:
>
> [ 250/4070] Compiling IDL librpc/idl/auth.idl
> /home/rsharpe/samba/samba.master-2/librpc/idl/auth.idl:112: warning:
> helper() is pidl-specific and deprecated. Use `include' instead
> /home/rsharpe/samba/samba.master-2/librpc/idl/auth.idl:104: error:
> Unable to determine origin of type `struct cli_credentials'
> /home/rsharpe/samba/samba.master-2/librpc/idl/auth.idl:104: error:
> Unable to determine origin of type `struct cli_credentials'
>
> Shouldn't those last two be fixed?

So, I tried fixing the first part of this with the following change:

diff --git a/librpc/idl/auth.idl b/librpc/idl/auth.idl
index 0bed671..57bbcd4 100644
--- a/librpc/idl/auth.idl
+++ b/librpc/idl/auth.idl
@@ -1,4 +1,5 @@
 #include "idl_types.h"
+#include "../../librpc/ndr/ndr_auth.h"

 /*
   Authentication IDL structures
@@ -12,7 +13,7 @@
 import "misc.idl", "security.idl", "lsa.idl", "krb5pac.idl";
 [
        pyhelper("librpc/ndr/py_auth.c"),
-       helper("../librpc/ndr/ndr_auth.h"),
+/*     helper("../librpc/ndr/ndr_auth.h"),*/
        helpstring("internal Samba authentication structures")
 ]

and I ran into a message from build that said: "You are in a twisty
maze of include files that lead nowhere ..."

WAF_MAKE=1 python ./buildtools/bin/waf build
Waf: Entering directory `/home/rsharpe/samba/samba.master-2/bin'
        Selected embedded Heimdal build
[ 250/4070] Compiling IDL librpc/idl/auth.idl
In file included from
/home/rsharpe/samba/samba.master-2/librpc/idl/auth.idl:2:0:
/home/rsharpe/samba/samba.master-2/librpc/idl/../../librpc/ndr/ndr_auth.h:26:37:
fatal error: librpc/gen_ndr/ndr_auth.h: No such file or directory
 #include "librpc/gen_ndr/ndr_auth.h"
                                     ^
compilation terminated.

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)