[PATCH] fix some parts of "samba-tool dns serverinfo ...."
Jelmer Vernooij
jelmer at samba.org
Sun Nov 9 06:01:00 MST 2014
On Sun, Nov 09, 2014 at 08:12:55AM +0100, Günter Kukkukk wrote:
> The attached patch fixes the IPv6 related infos in
> samba-tool dns serverinfo <some-server>
>
> Due to many missing pieces in the samba code, the IPv6 info can
> atm only be queried from MS servers:
>
> The obviously *wrong* IPv6 display:
> pszServerName : w08r2.addlz.kukkukk.com
> pszDsContainer : cn=MicrosoftDNS,cn=System,DC=addlz,DC=kukkukk,DC=com
> aipServerAddrs : ['00:00:2a2:819:8f40:11e0:a1a2:fff8 (53)', '00:00:fd4d:e013:bb96:a6c:00:00 (53)', '00:00:fd4d:e013:bb96:a6c:a1a2:fff8
> (53)', '00:00:fe80:00:00:00:a1a2:fff8 (53)', '192.168.200.81 (53)']
> aipListenAddrs : ['00:00:fd4d:e013:bb96:a6c:00:00 (53)', '00:00:fe80:00:00:00:a1a2:fff8 (53)', '192.168.200.81 (53)']
> aipForwarders : ['192.168.200.70 (53)']
>
> Fixed one:
>
> pszServerName : w08r2.addlz.kukkukk.com
> pszDsContainer : cn=MicrosoftDNS,cn=System,DC=addlz,DC=kukkukk,DC=com
> aipServerAddrs : ['2a02:8109:8f40:11e0:a1a2:fff8:4aa6:3613 (53)', 'fd4d:e013:bb96:a60c:0000:0000:0000:0051 (53)',
> 'fd4d:e013:bb96:a60c:a1a2:fff8:4aa6:3613 (53)', 'fe80:0000:0000:0000:a1a2:fff8:4aa6:3613 (53)', '192.168.200.81 (53)']
> aipListenAddrs : ['fd4d:e013:bb96:a60c:0000:0000:0000:0051 (53)', 'fe80:0000:0000:0000:a1a2:fff8:4aa6:3613 (53)', '192.168.200.81 (53)']
> aipForwarders : ['192.168.200.70 (53)']
>
> There are atm many missing pieces in the samba code regarding
> - IPv4/IPv6 addresses available on the samba host
> - IPv4/IPv6 addresses which samba bound to
> - dynamically enable/disable bound interfaces
> - ...
>
> The code is all there, but the API looks really strange to me.
We should really be using a standard formatting function for IPv6 addresses here.
For example, fd4d:e013:bb96:a60c:0000:0000:0000:0051 really should be formatted as
fd4d:e013:bb96:a60c::51.
Cheers,
Jelmer
--
Jelmer Vernooij <jelmer at samba.org>
More information about the samba-technical
mailing list