[PATCH] SMB2 AAPL create context (was: Mac OS Mavericks über slow)

Jeremy Allison jra at samba.org
Fri Nov 7 17:10:12 MST 2014


On Sat, Nov 01, 2014 at 08:43:14AM +0100, Ralph Böhme wrote:
> Hi Jeremy,
> 
> On Fri, Oct 31, 2014 at 01:58:38PM -0700, Jeremy Allison wrote:
> > Ralph, can you re-post the AAPL create context
> > patch with your latest changes ?
> > 
> > I'd love to get this reviewed and into the
> > code base now you're a Team member :-).
> 
> that would be great!
> 
> Patchset attached, couldn't rebase on master as sn is still down.

> diff --git a/source3/smbd/globals.h b/source3/smbd/globals.h
> index d0015d5..5137e5e 100644
> --- a/source3/smbd/globals.h
> +++ b/source3/smbd/globals.h
> @@ -504,6 +504,9 @@ struct smbXsrv_connection {
>  			uint32_t max_trans;
>  			uint32_t max_read;
>  			uint32_t max_write;
> +			bool use_aapl_crtctx;
> +			bool smb2_crtctx_aapl_readdir_attr;
> +			bool smb2_crtctx_aapl_unix_info;
>  		} server;
>  
>  		struct smbd_smb2_request *requests;

OK, adding these into the struct smbXsrv_connection is
*so* the wrong place to put these :-).

I'm not sure what the right place is yet, but I don't
think it's there... :-).

More when I've looked more closely.

Jeremy.


More information about the samba-technical mailing list