Latest leases patchset - getting there !

Jeremy Allison jra at
Fri Nov 7 13:13:13 MST 2014

On Fri, Nov 07, 2014 at 06:08:38PM +0100, Stefan (metze) Metzmacher wrote:
> tmp.diff.txt contains the grant_fsp_oplock_type() and brl_num_read changes
> Just tell me if they look ok for you, don't push them yet.

Oh - just one comment on the above

+void brl_set_num_read_oplocks(struct byte_range_lock *brl,
+                             uint32_t num_read_oplocks)
-       DEBUG(10, ("Setting have_read_oplocks to %s\n",
-                  have_read_oplocks ? "true" : "false"));
+       DEBUG(10, ("Setting have_read_oplocks to %"PRIu32"\n",
+                  num_read_oplocks));

You need to change the debug message to:

+       DEBUG(10, ("Setting num_read_oplocks to %"PRIu32"\n",
+                  num_read_oplocks));

(have_read_oplocks -> num_read_oplocks).



More information about the samba-technical mailing list