[PATCH 01/27] groupdb: don't leak state_path onto talloc tos

David Disseldorp ddiss at suse.de
Wed Nov 5 03:59:42 MST 2014

Hi Michael,

On Wed, 05 Nov 2014 08:34:04 +0000, Michael Croes wrote:

> Hi David,
> Isn't this missing 'talloc_free(tdb_path);' in 'if (ldb_path == NULL) {'?
> Regards,

Yes you're right. Also, I think the original code performs tdb cleanup
incorrectly - the group_mapping.tdb handle should be closed prior
to unlink() IIUC. But the fact that we're unlinking it in the first
place following failed group_mapping.ldb conversion looks risky.

Cheers, David

More information about the samba-technical mailing list