leak and possibly undefined behaviour using close in vfs_btrfs

Jeremy Allison jra at samba.org
Tue Nov 4 10:26:12 MST 2014


On Tue, Nov 04, 2014 at 04:43:53PM +0000, Noel Power wrote:
> Hi,
> 
> btrfs_get_compression routine closes file descriptor returned from
> dirfd, at best this leaks the DIR* at worst could introduce some
> undefined behaviour, please see attached patch (also opened bug 10918
> for that)

LGTM !

Reviewed-by: Jeremy Allison <jra at samba.org>


More information about the samba-technical mailing list