[PATCH 00/27] fix talloc stackframe leaks in remaining xx_path callers

David Disseldorp ddiss at suse.de
Sun Nov 2 16:14:11 MST 2014

On Mon, 03 Nov 2014 10:28:45 +1300, Andrew Bartlett wrote:

> > Feedback appreciated.  
> My preference is that functions never return memory on talloc_tos(), and
> that it (or better, a talloc_stackframe context) be passed in as the
> memory context.  That makes it clear what the allocation behaviour is.

I agree 100%.

This patch-set ensures that the allocated memory is explicitly freed
after use. Follow up changes to explicitly pass in talloc_tos() (or any
other context) should be pretty straight forward, and are certainly not
in any way impeded by this patch-set.

Cheers, David

More information about the samba-technical mailing list