[PATCHES] messaging iov / recvfrom

[Michael Adam]

On 2014-05-30 at 08:31 -0400, Simo wrote:
> On Fri, 2014-05-30 at 10:28 +0200, Michael Adam wrote:
> > On 2014-05-30 at 09:35 +0200, Andreas Schneider wrote:
> > > On Thursday 29 May 2014 14:31:55 Jeremy Allison wrote:
> > > > On Mon, May 26, 2014 at 05:07:44PM +0200, Michael Adam wrote:
> > > > > On 2014-05-26 at 15:52 +0200, Michael Adam wrote:
> > > > > > 
> > > > > > as a result of my work towards adding support for fd-passing
> > > > > > to our messaging, find attached two first preparatory patches
> > > > > > that might already be useful.
> > > > > > 
> > > > > > The first changes the send_fn to use struct  iovec
> > > > > > instead of data blob. (Volker has already looked
> > > > > > over this one.)
> > > > > > 
> > > > > > The second one lets unix_dgram_recv_handler()
> > > > > > use recvmsg() instead of recv().
> > > > > > 
> > > > > > Review/push/comments appreciated.
> > > > 
> > > > LGTM ! Pushed to autobuild.
> > >
> > > I gave a NAK! Why do you push it now?
> > 
> > I guess there was a misunderstanding.
> > I will post a follow-up patch to add the
> > missing checks for msg_control.
> 
> FWIW I was confused as well about the issue, what Andreas wanted to
> point out is that the member 'msg_control' is not always there on all
> platforms, so initializing it unconditionally will simply cause build
> issues.
> 
> However given we are initializing it to NULL, the solution is simply to
> omit the initialization, a memset is not necessary.

Right.
Part of the misunderstanding was due to the fact that we settled
the initializsation bit in chat after this start on the mailing
list. But the msg_control issue is of course valid.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140530/cb70e2f4/attachment.pgp>