[PATCHES] messaging iov / recvfrom

Andreas Schneider asn at samba.org
Fri May 30 01:35:06 MDT 2014


On Thursday 29 May 2014 14:31:55 Jeremy Allison wrote:
> On Mon, May 26, 2014 at 05:07:44PM +0200, Michael Adam wrote:
> > Oops, there was a bug in the first patch.
> > Sorry for posting prematurely...
> > Attaching a fixed version.
> > 
> > Thanks - Michael
> > 
> > On 2014-05-26 at 15:52 +0200, Michael Adam wrote:
> > > Hi,
> > > 
> > > as a result of my work towards adding support for fd-passing
> > > to our messaging, find attached two first preparatory patches
> > > that might already be useful.
> > > 
> > > The first changes the send_fn to use struct  iovec
> > > instead of data blob. (Volker has already looked
> > > over this one.)
> > > 
> > > The second one lets unix_dgram_recv_handler()
> > > use recvmsg() instead of recv().
> > > 
> > > Review/push/comments appreciated.
> 
> LGTM ! Pushed to autobuild.




I gave a NAK! Why do you push it now?







Look for

#ifdef HAVE_MSGHDR_MSG_CONTROL

in

source3/modules/vfs_aio_fork.c


and read the mail I wrote about that before! Michael agreed that we need to 
cleanup the msg_control detection and we already discussed how to do it!





	-- andreas, "the guy with a whip at SDC waiting for your arrival"

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list