vfs_streams_xattr: stream name prefix and type suffix

[Volker Lendecke]

On Mon, May 26, 2014 at 06:14:23PM +0200, Ralph Böhme wrote:
> thanks for spotting this one. Added an explicit talloc_strdup()
> hanging the string to off right talloc context.
> 
> Finally added a third commit with a patch for the manpage.
> 
> Fixed patches attached.

Some minor nit-picks, sorry for the second round...

> +	if (stype) {

Can we make this (stype != NULL) ?

>  		/* Normalize the stream type to upercase. */
>  		if (!strupper_m(strrchr_m(*xattr_name, ':') + 1)) {
>  			return NT_STATUS_INVALID_PARAMETER;
>  		}
> +	} else if (config->store_stream_type == true) {

This ==true discussion was meant as a joke :-)

I'd much rather see "if (config->store_stream_type) {"

> +		/* Append an explicit stream type if one wasn't specified. */
> +		*xattr_name = talloc_asprintf(ctx, "%s%s", *xattr_name, ":$DATA");

There's a few lines beyond 80 chars. Can you fix those?

> +	prefix = lp_parm_string_list(SNUM(handle->conn),
> +				     "streams_xattr", "prefix",
> +				     &default_prefix);

Why lp_parm_string_list here? Wouldn't lp_parm_const_string
do here?

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de