[PATCH 00/13]: Avoid duplicate libcli/secdesc usage

David Disseldorp ddiss at samba.org
Mon May 26 09:29:50 MDT 2014


There is currently a large amount of duplicate security descriptor
printing and handling code spread through Samba, particularly
across libcli/security/secdesc.[ch] and the newer IDL based
libcli/security/security_descriptor.[ch] library.

This change set starts to remove some of this duplicate and redundent
code.

--

The following changes since commit 5e892fb674c13e5a3b35b310557d1e2a43bd5bb5:

  s4-dns: dlz_bind9: improve log message consistency (2014-05-26 05:55:46 +0200)

are available in the git repository at:

  git://git.samba.org/ddiss/samba.git rm_dup_sd_code

for you to fetch changes up to 4cfb125c0cf37020430a17b408ad5e59c1db4619:

  libcli/secdesc: remove dup_sec_desc() (2014-05-26 16:25:31 +0200)

----------------------------------------------------------------
David Disseldorp (13):
      libcli/sd: remove redundant sec_desc_add_sid()
      libcli/sd: remove redundant sec_ace_add_sid()
      sharesec: use NDR security descriptor print fns
      sharesec: remove unused security descriptor print fns
      s3/rpc_server/spoolss: remove SETUP_SPOOLSS_NOTIFY_DATA_SECDESC
      s3/profiles: replace dup_sec_desc() usage
      s3/net_rpc_printer: replace dup_sec_desc() usage
      s3/posix_acls: replace dup_sec_desc() usage
      s3/rpc_server/spoolss: replace dup_sec_desc() usage
      s3/rpc_server/lsa: replace dup_sec_desc() usage
      libgpo: replace dup_sec_desc() usage
      libcli/secdesc: replace dup_sec_desc() usage
      libcli/secdesc: remove dup_sec_desc()

 libcli/security/secace.c                    |  26 --------------------------
 libcli/security/secace.h                    |   1 -
 libcli/security/secdesc.c                   |  56 +++++---------------------------------------------------
 libcli/security/secdesc.h                   |  10 ----------
 libgpo/gpo_util.c                           |   8 +++++++-
 source3/rpc_server/lsa/srv_lsa_nt.c         |   6 +++---
 source3/rpc_server/spoolss/srv_spoolss_nt.c |  28 ++++++++++++++++------------
 source3/smbd/posix_acls.c                   |   6 +++---
 source3/utils/net_rpc_printer.c             |  12 +++++++++++-
 source3/utils/profiles.c                    |  10 ++++++++--
 source3/utils/sharesec.c                    | 101 ++++++++++++-----------------------------------------------------------------------------------------
 11 files changed, 65 insertions(+), 199 deletions(-)




More information about the samba-technical mailing list