[PATCH] Fix RECVFILE with non-blocking sockets and add OEM recvfile call.

Jeremy Allison jra at samba.org
Thu May 22 10:59:51 MDT 2014

On Thu, May 22, 2014 at 06:18:30PM +0200, Stefan (metze) Metzmacher wrote:
> Am 22.05.2014 17:59, schrieb Jeremy Allison:
> > On Thu, May 22, 2014 at 02:59:09PM +0200, Stefan (metze) Metzmacher wrote:
> >>
> >> I'm getting EINVAL from splice if I use large io sizes, when using SMB3.
> >> When count is truncated to TRANSFER_BUF_SIZE (128*1024) it works fine.
> > 
> > OK, I'll fix up the 'standard' splice code on top of these patches
> > to make sure we don't go over 128k. Justin's splice changes won't
> > have that problem as he's using custom kernel code here.
> I was testing with a custom kernel! And the patches an OEM gave me look
> similar,
> but the have the chunking. With chunking it worked fine without I got a
> disconnect
> from the server.

Ah ok, didn't know you were testing with that :-).

When you say "have the chunking" do you mean with the
128k count limit ?

> For the 'standard' splice we could use larger chunks, as current kernel
> allow
> F_SETPIPE_SZ up to 1MB.

OK, I'll make this configurable.


More information about the samba-technical mailing list