[PATCH] Add protocol version to smbstatus output

Stefan (metze) Metzmacher metze at samba.org
Thu May 22 03:24:48 MDT 2014


Hi Mathias,

this version applies to master.
If this is fine for you (I added your sign-off), we need a 2nd team
member to review and push this.

metze

> "Stefan (metze) Metzmacher" <metze at samba.org> wrote on 05/21/2014
> 08:15:03 PM:
> 
>> From: "Stefan (metze) Metzmacher" <metze at samba.org>
>> To: Mathias Dietz/Germany/IBM at IBMDE
>> Cc: samba-technical at samba.org
>> Date: 05/21/2014 08:15 PM
>> Subject: Re: [PATCH] Add protocol version to smbstatus output
>> 
>> Hi Mathias,
>> 
>> > +   switch(global->connection_dialect){
>> > +   case SMB2_DIALECT_REVISION_000:
>> > +      fstrcpy(session.protocol_ver,"NT1");
>> > +      break;
>> > +   case SMB2_DIALECT_REVISION_202:
>> > +      fstrcpy(session.protocol_ver,"SMB2_00");
>> > +         break;
>> 
>> This should be SMB2_02.
>> 
>> > +   case SMB2_DIALECT_REVISION_210:
>> > +      fstrcpy(session.protocol_ver,"SMB2_10");
>> > +         break;
>> > +   case SMB2_DIALECT_REVISION_222:
>> > +      fstrcpy(session.protocol_ver,"SMB2_22");
>> > +         break;
>> > +   case SMB2_DIALECT_REVISION_224:
>> > +      fstrcpy(session.protocol_ver,"SMB2_24");
>> > +         break;
>> > +   case SMB3_DIALECT_REVISION_300:
>> > +      fstrcpy(session.protocol_ver,"SMB3_00");
>> > +         break;
>> 
>> Please also add SMB3_02.
>> 
>> Thanks!
>> 
>> metze
>> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tmp.diff
Type: text/x-diff
Size: 3168 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140522/8b8e48ca/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140522/8b8e48ca/attachment.pgp>


More information about the samba-technical mailing list