[PATCH] Fix RECVFILE with non-blocking sockets and add OEM recvfile call.
jra at samba.org
Wed May 21 11:25:41 MDT 2014
On Thu, May 08, 2014 at 02:28:08PM -0700, Jeremy Allison wrote:
> Hi all,
> Here are two patches to fix non-blocking RECVFILE
> for OEMs who use a modified kernel
> that allows splice to move data directly
> from socket to file instead of going
> via a pipe.
> The first patch is the one that Jones
> tested to ensure that the default
> implementation of sys_recvfile
> copes correctly with a non-blocking
> socket. This one just needs second
> team review.
> The second one is the patch that
> NetGear uses in their boxes in
> conjunction with their custom
> kernel splice code that allows
> direct recvfile from socket fd
> to file fd. This was was Signed-off-by
> Justin Maggard <jmaggard at netgear.com>
> (Justin has sent in the GPL assignment
> form) and reviewed by me and just needs
> a second Team reviewer. They want
> to push it upstream to prevent them
> from having to maintain it as an
> out-of-tree patch.
> It doesn't compile by default, but
> #define HAVE_LINUX_SPLICE_FROM_SOCKET
> set inside local.h.
> Please review and push if you're
> happy !
Ping ! I meant to raise this and get
it reviewed @ SambaXP, but didn't
get time :-).
Can I get a review on these two please
(it's been pending since May 8th, so
I think I'm entitled to push :-).
More information about the samba-technical