[PATCH] Do not reset the secrets.tdb SID and GUID when not required

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed May 21 05:56:49 MDT 2014

On Wed, May 21, 2014 at 01:49:53PM +0200, Andreas Schneider wrote:
> Some time ago I summarized our coding style rules and the ideas behind it in a 
> blog post:
> https://blog.cryptomilk.org/2013/03/28/writing-and-reading-code/
> So 'if (!dom_sid_equal())' is by our coding style definition allowed but the 
> extra bool ok is appreciated :)

By that blog post (ok == false) is clearer. Quote:

> if (c == false) {
>     return;
> }

This comes with another Quote:

> If you look at the code now, you can probably guess what
> types they are. 

So my question remains: Do we in the future forbid !ok and mandate
ok==false, such that the type of "ok" becomes cleaner?

With best regards,

Volker Lendecke

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list