[PATCH] Do not reset the secrets.tdb SID and GUID when not required

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon May 19 14:55:19 MDT 2014

On Wed, May 14, 2014 at 05:33:59PM +1200, Andrew Bartlett wrote:
> This patch avoids a valigrind error caused because the memory from
> get_global_sam_sid() was being cleared too often.

Can you describe what the valgrind error was?

Also, a style comment:

> +	if (ret) {
> +		if (dom_sid_equal(get_global_sam_sid(), sid) == false) {

I'd rather write !dom_sid_equal(). Any reason why you chose
== false?



SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list