[Review Request] libwbclient-sssd

[Sumit Bose]

On Fri, May 09, 2014 at 11:13:28AM -0700, Jeremy Allison wrote:
> On Fri, May 09, 2014 at 06:52:58PM +0200, Sumit Bose wrote:
> > Hi,
> > 
> > I'm looking for review and comments on my patches in
> > http://fedorapeople.org/cgit/sbose/public_git/samba.git/log/ .
> > 
> > They add a replacement for libwbclient which talks to SSSD
> > (https://fedorahosted.org/sssd/) instead of winbindd. One of the
> > use-cases for this library is to run Samba on FreeIPA clients where the
> > FreeIPA domain already has a trust relationship to an AD forest.
> > 
> > Currently not all calls are implemented but it already works quite well.
> > I would prefer to maintain this library in the Samba source tree
> > instead e.g. in the SSSD tree. We already have a id-mapping plugin for
> > cifs-utils in the SSSD tree but here the plugin interface is very small
> > and I think chances are low that it will change any time soon.
> > libwbclient on the other hand is more complex and contains quite some
> > calls which are independent of the backend (e.g. memory management and
> > conversion utilities). I tired to extract this common code in some of
> > the patches so that it can be used by both libraries.
> > 
> > Please let me know if you think that those patches can be included in
> > the samba tree (and what I have to fix/change to make it happen) or if
> > you think it would be better to maintain it externally?
> 
> +#define CHECK_CTX do { \
> +	if (ctx == NULL) { \
> +		open_libnss_sss(); \
> +		if (ctx == NULL) { \
> +			return WBC_ERR_NSS_ERROR; \
> +		} \
> +	} \
> +} while (0)
> 
> is an evil flow-control changing macro... :-)
> 
> I'd ditch that to start ;-).

Thank you for your comment, I ditched the macro completly in the current
version of my git tree.

bye,
Sumit

> 
> Jeremy.