[CIFS][PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()

Bjoern Baumbach bb at sernet.de
Fri May 16 06:09:40 MDT 2014


Hi Steve,

since 3.14.0 the creation of mf-symlinks is broken.
The creation fails with ENOENT, because it tries to just open it instead
of the creation.
I assume that this is a small copy-paste mistake from
cifs_query_mf_symlink().

Please find the patch attached. Can you review and push it to the Linux
sources, please?

Best regards,
Björn

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
>From 4cff7767e41b03014e03b6d5b8fbf5bbca67eb8f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Baumbach?= <bb at sernet.de>
Date: Thu, 15 May 2014 14:03:38 +0200
Subject: [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
changed disposition to FILE_OPEN.

Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Cc: <stable at vger.kernel.org> # v3.14
---
 fs/cifs/link.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/link.c b/fs/cifs/link.c
index 264ece7..68559fd 100644
--- a/fs/cifs/link.c
+++ b/fs/cifs/link.c
@@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
 	oparms.cifs_sb = cifs_sb;
 	oparms.desired_access = GENERIC_WRITE;
 	oparms.create_options = create_options;
-	oparms.disposition = FILE_OPEN;
+	oparms.disposition = FILE_CREATE;
 	oparms.path = path;
 	oparms.fid = &fid;
 	oparms.reconnect = false;
-- 
1.7.9.5


More information about the samba-technical mailing list