[PATCH] Fix winbind connections as non-root and test winbind auth modules

[Andrew Bartlett]

On Fri, 2014-05-16 at 09:58 +0200, Andreas Schneider wrote:
> On Friday 16 May 2014 14:47:12 Andrew Bartlett wrote:
> > This patch series adds a new baseline test to validate winbind auth
> > modules, to ensure that they continue to return the correct details
> > while we change winbindd itself.
> > 
> > In writing this, I found a nasty little bug (caused by a
> > misinterpretation of the requirements) in the use of the new UID_WRAPPER
> > stuff.   That is, a check for root ownership of the socket (or current
> > user) was mis-configured to be some kind of privilege check.
> 
> Hi Andrew,
> 
> thanks for the work on this. NAK on the first patch. Could you please take a 
> look at the attached patch and you this one. Feel free to push it then with my 
> RB+.

Attached with your review markers and my review of your changes.  It
passes the same tests that my original code does.  Let me know that this
is all OK and I'll send it off to autobuild.

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-nsswitch-Fix-the-check-for-the-privileged-pipe.patch
Type: text/x-patch
Size: 2797 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140516/01efa347/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-selftest-Run-pdbtest-under-valgrind-if-specified.patch
Type: text/x-patch
Size: 1009 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140516/01efa347/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-auth-Allow-auth_samba4-to-be-forced-to-run-a-specifi.patch
Type: text/x-patch
Size: 7004 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140516/01efa347/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-selftest-Test-auth_wbc-the-auth4-winbind-and-winbind.patch
Type: text/x-patch
Size: 9286 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140516/01efa347/attachment-0003.bin>