[PATCH] talloc: Tune talloc_vasprintf
Volker.Lendecke at SerNet.DE
Thu May 15 02:19:53 MDT 2014
On Thu, May 15, 2014 at 10:17:02AM +0200, Stefan (metze) Metzmacher wrote:
> Hi Volker,
> > A patch from my attic: In some profiles vsnprintf showed up
> > high from talloc_asprintf. This cuts vsnprintf use in
> > talloc_asprintf by half in most cases.
> > Review would be appreciated!
> Do you think it would make sense to use PATH_MAX instead of 1024?
Sure, we could do this. It's just that this routine has
nothing to do with file names or paths. PATH_MAX might make
people wonder why we refer to that in this routine.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical