[PATCH] Add back --with-fake-kaserver option to the build

Andrew Bartlett abartlet at samba.org
Wed May 14 16:28:52 MDT 2014


On Wed, 2014-05-14 at 16:32 +0200, Christian Ambach wrote:
> Hi list,
> 
> here is an updated patchset that now allows building against OpenAFS 1.6.
> 
> Please review so Bug 9916 can be closed.

This moves the util_sec.c code around, and as far as I can tell it is
only to support this fragment:

	if (geteuid() != sec_initial_uid())
		ct.ViceId = getuid();

This will always execute (because set_init() hasn't been called), so it
seems pointless in wbinfo.  It will be much less confusing if this is
pushed to the caller, and util_sec.c not invoked.

Given other alternative, I don't want util_sec.c moved to the top level,
because it only works properly in binaries that call sec_init(), which
is currently only the core source3 binaries. 

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list