[PATCH] Fix bug #10587 - Opening directories on SLES's cifsd and Apple's smbx succeeds.

[Jeremy Allison]

On Fri, May 09, 2014 at 11:06:51PM +0200, Stefan (metze) Metzmacher wrote:
> Am 09.05.2014 17:36, schrieb Jeremy Allison:
> > On Thu, May 08, 2014 at 09:39:21PM -0700, Jeremy Allison wrote:
> >> On Thu, May 08, 2014 at 07:54:05PM -0700, Jeremy Allison wrote:
> >>> On Thu, May 08, 2014 at 07:47:34PM -0700, Jeremy Allison wrote:
> >>>> On Fri, May 09, 2014 at 12:19:11AM +0200, Stefan (metze) Metzmacher wrote:
> >>>>
> >>>>> Please avoid the ugly _internal_recv() function,
> >>>>> just expose the attrs in the normal _recv and the sync function.
> >>>>
> >>>> That means changing the ABI to the cli_ntcreate_recv().
> >>>> I thought this was already exposed to external callers,
> >>>> but checking I guess we're not guarenteeing this
> >>>> interface externally.
> >>>>
> >>>> OK, I'll fix it up to be the same as the smb2
> >>>> version of the function that returns a struct
> >>>> containing the full data returned from the
> >>>> open in the _recv call.
> >>>
> >>> FYI - If I do it this way it's a *much*
> >>> bigger change, as it means changing
> >>> every caller of cli_ntcreate() and
> >>> also cli_nttrans_create() as well
> >>> (as we'll need the same return values
> >>> here).
> >>
> >> All right Metze, here's the goddam rewrite
> >> you insisted upon :-).
> >>
> >> Add a return parameter of struct smb_create_returns *cr to
> >> cli_ntcreate()
> >> cli_ntcreate_recv()
> >> cli_nttrans_create()
> >> cli_nttrans_create_recv()
> >>
> >> and fixes everything up... It's now a 4-patch set.
> >>
> >> Please review. *Now* will you be happy ! :-).
> > 
> > Metze - ping. Spent a lot of time doing this
> > last night, would be good to get it reviewed
> > before I leave for SambaXP.
> 
> I tried a few times to push today, but it failed all time
> because of the GETADDRINFO test.
> 
> I'll repush now :-)

Thanks, much appreciated :-).