[PATCH] Fix bug #10587 - Opening directories on SLES's cifsd and Apple's smbx succeeds.
jra at samba.org
Thu May 8 14:57:43 MDT 2014
On Thu, May 08, 2014 at 01:32:16PM -0700, Jeremy Allison wrote:
> On Thu, May 08, 2014 at 09:58:19PM +0200, Stefan (metze) Metzmacher wrote:
> > This is too much magic if the cli_foo() behaves differently as
> > cli_foo_send/recv().
> Yeah, I had qualms about it too, but it's the simplest
> fix I could come up with - not being able to change
> the gvfs or other libsmbclient callers.
> Or do you mean putting this change inside libsmbclient ?
> There is also precedence for this kind of change
> based on the fallback code inside cli_open() that
> tries ntcreateX first, and then fall back to
> openX if the server returns specific error codes:
OK, how about the following. It puts all the
uglyness inside cli_open(), which is the
meta-call used by libsmbclient and smbclient.
As there is no cli_open_send() and cli_open_recv()
I think we're safe having different behavior
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 6330 bytes
Desc: not available
More information about the samba-technical