[PATCH] We should return WERR_BADFILE in _srvsvc_NetShareAdd if the path does not exist

Andrew Bartlett abartlet at samba.org
Wed May 7 23:01:43 MDT 2014

On Mon, 2014-04-21 at 15:49 -0700, Jeremy Allison wrote:
> On Tue, Apr 22, 2014 at 12:35:18AM +0200, David Disseldorp wrote:
> > On Mon, 21 Apr 2014 14:02:02 -0700, Jeremy Allison wrote:
> > 
> > > > This patch allows Windows and things like Hyena to work more correctly:  
> > > 
> > > Here is a version for master (and CC:ed to samba-technical). Let me know
> > > if you're OK with it. Cheers,
> > 
> > Any reason for bypassing the VFS here? Otherwise the patch looks okay.
> There is no share to use to go through the VFS - it
> is a request to create one.
> This is the client sending a raw file system
> path to set up as a share.

We can still connect directly to the file system.  It is a mess - many
modules fail to operate without a valid connect() call first, but for
better or worse, the 'samba-tool ntacl' tools do work directly on

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list