[PATCH] byteorder: do not assume PowerPC is big-endian

David Disseldorp ddiss at suse.de
Tue May 6 04:20:38 MDT 2014


On Tue, 06 May 2014 11:34:26 +1200, Andrew Bartlett wrote:

> ./configure
> 
> sort bin/default/include/config.h > /tmp/config.h.sorted
> git am *.patch
> ./configure
> 
> sort bin/default/include/config.h > /tmp/config.h.sorted-new
> diff -u /tmp/config.h.sorted /tmp/config.h.sorted-newer 
> 
> The only change should be this (or similar):
> @@ -1105,5 +1105,4 @@
>  /* #undef SYSCONF_SC_NPROC_ONLN */
>  /* #undef USE_DMAPI */
>  /* #undef USE_LINUX_32BIT_SYSCALLS */
> -/* #undef WORDS_BIGENDIAN */
>  /* #undef XATTR_ADDITIONAL_OPTIONS */

There's no change, as 0001-build-unify-and-fix-endian-tests.patch keeps
the WORDS_BIGENDIAN definition.
I'll work converting users to HAVE_BIG_ENDIAN so it can be removed, as
suggested by Christof.

> If so, can you push both this and whatever version of the byteorder.h
> patch set Christof is happy with?

The changes look good, pushed to autobuild.

Cheers, David


More information about the samba-technical mailing list