[PATCH] swrap: Use the loaded libc open() directly.
Volker.Lendecke at SerNet.DE
Mon May 5 22:29:43 MDT 2014
On Mon, May 05, 2014 at 11:36:12AM +0200, Volker Lendecke wrote:
> On Mon, May 05, 2014 at 11:30:05AM +0200, Stefan (metze) Metzmacher wrote:
> > The history is available at
> > https://git.samba.org/?p=socket_wrapper.git;a=summary
> > The happens similar to an import of heimdal. We only import the files we
> > need
> > (socket_wrapper.c in this case) of a wellknown snapshot of the external
> > project.
> > And 'wscript' is only part of the samba tree.
> > https://git.samba.org/?p=asn/samba.git;a=commitdiff;h=4d854b8148e367f47fec132afa99d9082d78fd29
> > gets my review because the content of socket_wrapper.c (95643aa) is the
> > same as
> > last change in socket wrapper 1.0.2, see
> > https://git.samba.org/?p=socket_wrapper.git;a=commitdiff;h=eb6676b6ed0f25a45fb3a7c04633aa83f378c23d
> > I'm fine if we would also add the hash of the socket_wrapper-1.0.2 tag
> > and a reference to the repository url into the commit message...
> I would really stronly prefer if we could see the socket
> wrapper commit history in Samba's commit history. Socket
> wrapper has a strong history in Samba, heimdal does not.
> Please keep the commit history inside Samba complete.
> Possibly for this we should do merges?
Ok, nobody stepped up to support my opinion. Please just put
it in as it is. I take back my -1 on this.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical