[PATCH] swrap: Use the loaded libc open() directly.

[Stefan (metze) Metzmacher]

Hi Volker,

>>> Andreas' socket wrapper repo contains a ciritical bug fix
>>> that should go into Samba master asap. Attached find the
>>> version that applies to master. Please review & push!
>>>
>>> Thanks,
>>>
>>> Volker
>>
>> Please do not push this patch. Use the patch from
>>
>> https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/swrap
> 
> -1 on this one.
> 
> Here we lose the commit history with the individual
> bugfixes. Just "socket wrapper 1.0.2" is not sufficient to
> find the individual patches. Please rebase the individual
> patches from socket wrapper.

The history is available at
https://git.samba.org/?p=socket_wrapper.git;a=summary
The happens similar to an import of heimdal. We only import the files we
need
(socket_wrapper.c in this case) of a wellknown snapshot of the external
project.
And 'wscript' is only part of the samba tree.

https://git.samba.org/?p=asn/samba.git;a=commitdiff;h=4d854b8148e367f47fec132afa99d9082d78fd29
gets my review because the content of socket_wrapper.c (95643aa) is the
same as
last change in socket wrapper 1.0.2, see
https://git.samba.org/?p=socket_wrapper.git;a=commitdiff;h=eb6676b6ed0f25a45fb3a7c04633aa83f378c23d

I'm fine if we would also add the hash of the socket_wrapper-1.0.2 tag
and a reference to the repository url into the commit message...

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140505/02e79ee1/attachment.pgp>