[PATCHES] improve debug messages in pdb_default_sid_to_id()

[Michael Adam]

Attached find two patches that fix and improve
debug messages in pdb_default_sid_to_id().

Review / push appreciated.

Thanks - Michael
-------------- next part --------------
From e236806b8f679da56ac36e9ca5ecdb8eec9a17b0 Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Wed, 30 Apr 2014 12:10:01 +0200
Subject: [PATCH 1/2] s3:passdb: fix and improve debug message in
 pdb_default_sid_to_id().

Signed-off-by: Michael Adam <obnox at samba.org>
---
 source3/passdb/pdb_interface.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/source3/passdb/pdb_interface.c b/source3/passdb/pdb_interface.c
index 7a0a824..a2939b7 100644
--- a/source3/passdb/pdb_interface.c
+++ b/source3/passdb/pdb_interface.c
@@ -1494,7 +1494,8 @@ static bool pdb_default_sid_to_id(struct pdb_methods *methods,
 				ret = false;
 			}
 		} else {
-			DEBUG(5, ("SID %s is or domain, but is unmapped\n",
+			DEBUG(5, ("SID %s belongs to our domain, but there is "
+				  "no corresponding object in the database.\n",
 				  sid_string_dbg(sid)));
 		}
 		goto done;
-- 
1.7.5.4


From f293efdf1cdab54b44537221dd8ac47a87d3a83f Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Wed, 30 Apr 2014 12:14:46 +0200
Subject: [PATCH 2/2] s3:passdb: improve a debug message in
 pdb_default_sid_to_id()

Signed-off-by: Michael Adam <obnox at samba.org>
---
 source3/passdb/pdb_interface.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/source3/passdb/pdb_interface.c b/source3/passdb/pdb_interface.c
index a2939b7..8774da1 100644
--- a/source3/passdb/pdb_interface.c
+++ b/source3/passdb/pdb_interface.c
@@ -1489,7 +1489,10 @@ static bool pdb_default_sid_to_id(struct pdb_methods *methods,
 				id->id = uid;
 				break;
 			default:
-				DEBUG(5, ("SID %s is our domain, but is not mapped to a user or group (got %d)\n",
+				DEBUG(5, ("SID %s belongs to our domain, and "
+					  "an object exists in the database, "
+					   "but it is neither a user nor a "
+					   "group (got type %d).\n",
 					  sid_string_dbg(sid), type));
 				ret = false;
 			}
-- 
1.7.5.4

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140503/6ba8b390/attachment.pgp>