[PATCH] Use idmap cache for all pdb backends.

Michael Adam obnox at samba.org
Fri May 2 17:51:57 MDT 2014


On 2014-05-02 at 17:19 +0300, Alexander Bokovoy wrote:
> On Fri, May 2, 2014 at 4:38 PM, Alexander Werth
> <werth at linux.vnet.ibm.com> wrote:
> > On Wed, 2014-04-30 at 15:46 -0700, Christof Schmitt wrote:
> >>
> >> Why are you removing the caching in pdb_ldap? As far as i can see,
> >> ldapsam_sid_to_id, ldapsam_uid_to_sid and ldapsam_gid_to_sid do not call
> >> the default methods, so the cache calls should probably be kept in the
> >> ldapsam functions.
> >
> > Right, I meant to move that call up one level but didn't.
> > What about this version of the patch?
> > I've added the cache call right into pdb_sid_to_id, pdb_uid_to_sid, and
> > pdb_gid_to_sid which are calling the backend specific methods.
> Looks good now.
> You can add
> Reviewed-by: Alexander Bokovoy <ab at samba.org>

pushed to autobuild.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140503/726f0ddc/attachment.pgp>


More information about the samba-technical mailing list