[PATCH 3/3] build: make wafsamba WORDS_BIGENDIAN test cross-compile friendly

Andrew Bartlett abartlet at samba.org
Mon Mar 31 19:18:47 MDT 2014

On Mon, 2014-03-31 at 09:31 -0300, Gustavo Zacarias wrote:
> Use the same test as lib/ccan/wscript that's cross-compile friendly.
> These separate tests should probably be reconciled by moving everything
> into wafsamba.

I would prefer you did as suggested, and unified the whole test.  In
particular, coping over just the big-endian handling and assuming that
this macro being absent is authoritative for little-endian seems
dangerous, we should always do the fallback the ccan code does. 

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list