[PATCH] Make loadparm more common

Andrew Bartlett abartlet at samba.org
Sun Mar 30 22:11:34 MDT 2014

On Fri, 2014-03-28 at 13:42 +1300, Andrew Bartlett wrote:

> Even more patches are at
> http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/loadparm-talloc-to-review3
> Please review!  (I do realise that reviewing 98 patches will take some
> time, but if we can make a start on the first 14 that would be most
> helpful).


I've spent much of today running tests on the loadparm code, and I've
added in a talloc_tos() related fix at the start of the series. 

However, I also decided to run a test on every revision, to ensure we
don't end up in bisect failures in the future.  The problem test is the
test_defaults_s4 in the docs.py test, and starting at this commit it


This commit fixes it:

The rest of the tree seems fine, and so we can still ask for the first
55 patches to be reviewed while we work on these. 

BTW, The test I'm running on every single commit is:

make -j && make test TESTS="docs libsmbclient netapi testparm"

Additionally, the branch as a whole passes a full autobuild on


It would be great to get a review on this, so we can get at least the
first half into master.


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list