[PATCH] remove lp_ctx from tdb_wrap_open

Richard Sharpe realrichardsharpe at gmail.com
Sun Mar 30 17:49:48 MDT 2014


On Sun, Mar 30, 2014 at 11:35 AM, Volker Lendecke
<Volker.Lendecke at sernet.de> wrote:
> On Sun, Mar 30, 2014 at 08:12:56AM -0700, Richard Sharpe wrote:
>> On Fri, Mar 28, 2014 at 8:16 AM, Volker Lendecke
>> <Volker.Lendecke at sernet.de> wrote:
>> > Hi!
>> >
>> > If we want to merge with ctdb, this is required. Also find
>> > some messaging4 cosmetic patches.
>> >
>> > Review would be appreciated.
>>
>> tdb_wrap_open_ seems like an unusual idiom and could easily be
>> confused with tdb_wrap_open.
>>
>> I suggest _tdb_wrap_open or some other name.
>
> I can do that. But it is just a really temporary name that
> is removed in the same patchset again. Do you think it is
> really necessary?

Nope. I obviously did not notice that it was removed in the same patchset.

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)


More information about the samba-technical mailing list