change --picky-developer into --non-picky-developer

[Jelmer Vernooij]

On Fri, Mar 28, 2014 at 04:51:55PM +1300, Andrew Bartlett wrote:
> On Thu, 2014-03-27 at 21:57 +0100, Stefan (metze) Metzmacher wrote:
> > Am 27.03.2014 21:29, schrieb Andrew Bartlett:
> > > On Thu, 2014-03-27 at 15:34 +0100, Stefan (metze) Metzmacher wrote:
> > >> Am 27.03.2014 09:07, schrieb Andrew Bartlett:
> > >>> On Thu, 2014-03-13 at 09:24 +1300, Andrew Bartlett wrote:
> > >>>> On Wed, 2014-03-12 at 17:22 +0100, Stefan (metze) Metzmacher wrote:
> > >>>>> Hi,
> > >>>>>
> > >>>>> I've created a patchset that does fix a lot of compiler warnings
> > >>>>> and lets --enable-developer imply -Werror by default.
> > >>>>>
> > >>>>> This uses a allow_warnings argument to SAMBA_SUBSYSTEM/LIBRARY/MODULE,
> > >>>>> which is False by default. Which means autobuild will protect us
> > >>>>> from having new warnings introduced.
> > >>>>>
> > >>>>> If a developer has a compiler that generates more warnings
> > >>>>> (as the gcc from ubuntu 10.04 or 12.04) he needs
> > >>>>> --non-picky-developer in order to avoid -Werror.
> > >>>>>
> > >>>>> Overtime we can aim to add more -W* flags and
> > >>>>> reduce the number of allow_warnings=True usages.
> > >>>>>
> > >>>>> Please review and push
> > >>>>> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-picky
> > >>>>
> > >>>> Very interesting!  I'll look over this today!
> > >>>
> > >>> Can we fixed this by changing the macro or re-ordering, rather than
> > >>> omitting the ; which just looks weird?
> > >>
> > >> Something like this?
> > >>
> > >> https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=b1d0143980f0e9d8427bf822472fd05a935ce374
> > > 
> > > Yes, much better.
> > 
> > Ok, I fixed up
> > https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-picky
> 
> That looks better, and I'll keep looking over it.  Garming fixed some of
> the same things in loadparm in his patch set, and I would like to get
> this rebased on his changes, and both sets into master. 

Can we make it --lenient-developer rather than --non-picky-developer ?
:-)

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140328/927185a8/attachment.pgp>