change --picky-developer into --non-picky-developer

Stefan (metze) Metzmacher metze at samba.org
Thu Mar 27 08:34:22 MDT 2014


Am 27.03.2014 09:07, schrieb Andrew Bartlett:
> On Thu, 2014-03-13 at 09:24 +1300, Andrew Bartlett wrote:
>> On Wed, 2014-03-12 at 17:22 +0100, Stefan (metze) Metzmacher wrote:
>>> Hi,
>>>
>>> I've created a patchset that does fix a lot of compiler warnings
>>> and lets --enable-developer imply -Werror by default.
>>>
>>> This uses a allow_warnings argument to SAMBA_SUBSYSTEM/LIBRARY/MODULE,
>>> which is False by default. Which means autobuild will protect us
>>> from having new warnings introduced.
>>>
>>> If a developer has a compiler that generates more warnings
>>> (as the gcc from ubuntu 10.04 or 12.04) he needs
>>> --non-picky-developer in order to avoid -Werror.
>>>
>>> Overtime we can aim to add more -W* flags and
>>> reduce the number of allow_warnings=True usages.
>>>
>>> Please review and push
>>> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-picky
>>
>> Very interesting!  I'll look over this today!
> 
> Can we fixed this by changing the macro or re-ordering, rather than
> omitting the ; which just looks weird?

Something like this?

https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=b1d0143980f0e9d8427bf822472fd05a935ce374

metze


More information about the samba-technical mailing list