change --picky-developer into --non-picky-developer

[Andrew Bartlett]

On Thu, 2014-03-13 at 09:24 +1300, Andrew Bartlett wrote:
> On Wed, 2014-03-12 at 17:22 +0100, Stefan (metze) Metzmacher wrote:
> > Hi,
> > 
> > I've created a patchset that does fix a lot of compiler warnings
> > and lets --enable-developer imply -Werror by default.
> > 
> > This uses a allow_warnings argument to SAMBA_SUBSYSTEM/LIBRARY/MODULE,
> > which is False by default. Which means autobuild will protect us
> > from having new warnings introduced.
> > 
> > If a developer has a compiler that generates more warnings
> > (as the gcc from ubuntu 10.04 or 12.04) he needs
> > --non-picky-developer in order to avoid -Werror.
> > 
> > Overtime we can aim to add more -W* flags and
> > reduce the number of allow_warnings=True usages.
> > 
> > Please review and push
> > https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-picky
> 
> Very interesting!  I'll look over this today!

Can we fixed this by changing the macro or re-ordering, rather than
omitting the ; which just looks weird?

commit e3c0dec432a4d55912d9eadbef28d2671543a2e1
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Feb 27 09:29:36 2014 +0100

    s4:smbd: remove unused ';' after STATIC_*_MODULES_PROTO
    
    The compiler treats this as code that needs to be executed
    and generates warnings with -Wdeclaration-after-statement.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>

diff --git a/source4/smbd/process_model.c b/source4/smbd/process_model.c
index bbcbe3b..99fd4ef 100644
--- a/source4/smbd/process_model.c
+++ b/source4/smbd/process_model.c
@@ -102,7 +102,7 @@ _PUBLIC_ NTSTATUS register_process_model(const
struct model_ops *ops)
 _PUBLIC_ NTSTATUS process_model_init(struct loadparm_context *lp_ctx)
 {
 #define _MODULE_PROTO(init) extern NTSTATUS init(void);
-       STATIC_process_model_MODULES_PROTO;
+       STATIC_process_model_MODULES_PROTO
        init_module_fn static_init[] = { STATIC_process_model_MODULES };
        init_module_fn *shared_init;
        static bool initialised;


-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba