[PATCH] samba-tool dbcheck: handle missing objectClass

[Andrew Bartlett]

On Wed, 2014-03-26 at 09:07 +0100, Stefan (metze) Metzmacher wrote:

> Can you keep this unless the DBCHECK control is specified ?

Certainly.  See attached. 

> > -	/*
> > -	 * Now check if this objectClass means we need to do urgent replication
> > -	 */
> > -	if (!*is_urgent && replmd_check_urgent_objectclass(objectclass_el,
> > -							   situation)) {
> > -		*is_urgent = true;
> > +	if (objectclass_el != NULL) {
> > +		/*
> > +		 * Now check if this objectClass means we need to do urgent replication
> > +		 */
> > +		if (!*is_urgent && replmd_check_urgent_objectclass(objectclass_el,
> > +								   situation)) {
> > +			*is_urgent = true;
> > +		}
> >  	}
> >  
> >  	/*
> > -- 1.9.0
> > 
> > 
> > 0003-dsdb-Improve-errors-and-checks-for-missing-objectCla.patch
> > 
> > 
> > From 417ec4717fc6e7fe34788e88ca47fc144fdbda5f Mon Sep 17 00:00:00 2001
> > From: Andrew Bartlett <abartlet at samba.org>
> > Date: Wed, 26 Mar 2014 12:48:17 +1300
> > Subject: [PATCH 3/3] dsdb: Improve errors and checks for missing objectClass
> >  values
> > 
> > Change-Id: I8c4ac679accc90748d20c9c86986b127c939fa75
> > Signed-off-by: Andrew Bartlett <abartlet at samba.org>
> 
> Reviewed-by: Stefan Metzmacher <metze at samba.org>

Thanks!

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dsdb-Improve-missing-objectClass-handling.patch
Type: text/x-patch
Size: 2143 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140327/1f6b8ff1/attachment.bin>