smbd as a daemon

[Alexander Bokovoy]

On Tue, Mar 25, 2014 at 9:38 PM, Jeremy Allison <jra at samba.org> wrote:
> On Tue, Mar 25, 2014 at 09:28:34PM +0200, Alexander Bokovoy wrote:
>> >
>> > Ok, attached patch compiles for me and links libsystem-daemon
>> > properly. I'm going to run some package tests tomorrow.
>> Updated patch -- I forgot one define for non-systemd case and also
>> added changes to systemd services.
>
> Few comments inline.
>
>>   Become a daemon, discarding the controlling terminal.
>>  ****************************************************************************/
>>
>> -_PUBLIC_ void become_daemon(bool do_fork, bool no_process_group, bool log_stdout)
>> +_PUBLIC_ void become_daemon(bool do_fork, bool no_process_group, bool log_stdout, bool wait_for_child_init)
>
> What is the extra parameter 'bool wait_for_child_init' for ?
> In the calling code you're always passing it as 'true' so
> what does it achieve ?
I somehow thought I saw more become_daemon() uses. Looked again, I
don't see any more.
This should explain why I added it.
>
>> -             become_daemon(Fork, no_process_group, log_stdout);
>> +             become_daemon(Fork, no_process_group, log_stdout, True);
>
> Bah. We don't use 'True' anymore. If you do end up
> keeping the parameter please use 'true/false' in all
> new code.
Yes, changed it several times and missed here.

> Otherwise looks ok to me.
Updated patch attached, removed changes to become_daemon() prototype.

-- 
/ Alexander Bokovoy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-add-systemd-integration.patch
Type: text/x-diff
Size: 8766 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140325/02a0cd03/attachment.patch>