[PATCH] more FSRVP & additionally HRESULT error

[Noel Power]

Hi David,
On 25/03/14 12:38, David Disseldorp wrote:
> +typedef struct {uint32_t w;} HRESULT;
> +#define HRES_ERROR(x) ((HRESULT) { x })
> +#define HRES_ERROR_V(x) ((x).w)
>
> Please use a struct member var other than "w" or "v", so that these
> macros can't be mixed with the ntstatus and werror helpers.
>
> +#define HRES_IS_EQUAL(x,y) (HRES_ERROR_V(x) == HRES_ERROR_V(y))
>
> It's probably worth adding an HRES_IS_OK helper macro here too.
please see latest iteration
http://cgit.freedesktop.org/~noelp/noelp-samba/log/?h=heave_in_hresult-v5

thanks!

Noel