[PATCH] more FSRVP & additionally HRESULT error

Noel Power nopower at suse.com
Tue Mar 25 04:35:39 MDT 2014

Hi Metz,

On 18/03/14 07:04, Stefan (metze) Metzmacher wrote:
> Can you also publish the script you used?
> Similar to
> https://git.samba.org/?p=samba.git;a=blob;f=source4/scripting/bin/w32err_code.py;h=4ca6413e942
> The same applies to the HRESULT generation.
> It would be also good if you could split
> http://cgit.freedesktop.org/~noelp/noelp-samba/commit/?h=heave_in_hresult-v2&id=be6cc634b31777044e4c7d5c93d0124bc41ad1b7
> to that the libcli/util/ changes are in there own commit.
> The rest should be combined with
> http://cgit.freedesktop.org/~noelp/noelp-samba/commit/?h=heave_in_hresult-v2&id=d0e9479324893f35b52012d7bddb5f244471a94a
done, please see

On 19/03/14 13:30, Stefan (metze) Metzmacher wrote:
>> One thing I noticed is that you imported
>> NT_STATUS_RPC_NT_* values, while we already have some of them
>> as NT_STATUS_RPC_*. Can you change the import to use just NT_STATUS_RPC_*
>> and remove the once we already have?
> Please also change NT_STATUS_EPT_NT_* into just NT_STATUS_EPT_*
also done please see

note: I did unexpectedly find a duplicate with the NT_STATUS errors
after transforming the names as you requested. However, it appears that
the duplicate resulted from the original constant having an incorrect
error code defined ( see 3e4aead159ca0b6445a9e99b5b54b1cb58a55559 in
branch above )



More information about the samba-technical mailing list