[PATCH] more FSRVP & additionally HRESULT error
nopower at suse.com
Tue Mar 25 04:35:39 MDT 2014
On 18/03/14 07:04, Stefan (metze) Metzmacher wrote:
> Can you also publish the script you used?
> Similar to
> The same applies to the HRESULT generation.
> It would be also good if you could split
> to that the libcli/util/ changes are in there own commit.
> The rest should be combined with
done, please see
On 19/03/14 13:30, Stefan (metze) Metzmacher wrote:
>> One thing I noticed is that you imported
>> NT_STATUS_RPC_NT_* values, while we already have some of them
>> as NT_STATUS_RPC_*. Can you change the import to use just NT_STATUS_RPC_*
>> and remove the once we already have?
> Please also change NT_STATUS_EPT_NT_* into just NT_STATUS_EPT_*
also done please see
note: I did unexpectedly find a duplicate with the NT_STATUS errors
after transforming the names as you requested. However, it appears that
the duplicate resulted from the original constant having an incorrect
error code defined ( see 3e4aead159ca0b6445a9e99b5b54b1cb58a55559 in
branch above )
More information about the samba-technical