[PATCH] Storing the ACL control flags with vfs gpfs.

[Jeremy Allison]

On Fri, Mar 21, 2014 at 03:07:44PM -0700, Christof Schmitt wrote:
> On Fri, Mar 21, 2014 at 04:47:39PM +0100, Alexander Werth wrote:
> > diff --git a/source3/modules/nfs4_acls.c b/source3/modules/nfs4_acls.c
> > index 774c40e..3edb321 100644
> > --- a/source3/modules/nfs4_acls.c
> > +++ b/source3/modules/nfs4_acls.c
> > @@ -49,6 +49,7 @@ typedef struct _SMB_ACE4_INT_T
> >  typedef struct _SMB_ACL4_INT_T
> >  {
> >  	uint32	magic;
> > +	uint16_t	controlflags;
> >  	uint32	naces;
> >  	SMB_ACE4_INT_T	*first;
> >  	SMB_ACE4_INT_T	*last;
> > @@ -218,6 +219,7 @@ SMB4ACL_T *smb_create_smb4acl(TALLOC_CTX *mem_ctx)
> >  		return NULL;
> >  	}
> >  	theacl->magic = SMB_ACL4_INT_MAGIC;
> > +	theacl->controlflags = SEC_DESC_SELF_RELATIVE;
> >  	/* theacl->first, last = NULL not needed */
> >  	return (SMB4ACL_T *)theacl;
> >  }
> > @@ -288,6 +290,25 @@ uint32 smb_get_naces(SMB4ACL_T *theacl)
> >  	return aclint->naces;
> >  }
> >  
> > +uint16_t smb_get_controlflags(SMB4ACL_T *theacl)

smb_get_controlflags/smb_set_controlflags is too generic a name I'm afraid for
what this code does.

Can you change it to:

	uint16_t smb_get_nfsv4acl_controlflags(SMB4ACL_T *theacl)
	bool smb_set_nfsv4acl_controlflags(SMB4ACL_T *theacl, uint16_t controlflags)

Instead please ? I'll re-review once you've made that change.

Cheers,

	Jeremy.