[PATCH] Bug 10239 - log.nmbd never rotates
jra at samba.org
Mon Mar 24 12:52:55 MDT 2014
On Wed, Mar 19, 2014 at 04:32:38PM +0100, Bjoern Baumbach wrote:
> I've just figured out that we may need to the reset/reopen logs once
> again, in the case that we specify a different config file in the
> smb.conf via "config file" option.
> I've attached a new patch.
> It applies on master, 4-0-test and 4-1-test.
> If you think this patch is good, please feel free to push it. Then I'll
> attach the patch to the bug report.
Looks good to me - I'll push as soon as you re-send
with your Signed-off-by: line added :-).
Interestingly I looked at how smbd doesn't have
the same problem and it's because of the indirect
call to reopen_logs() from the reload_services()
call done after we've loaded the smb.conf.
More information about the samba-technical